V13: Eaglery route domains for virtual page controllers #16635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16626
This was caused because the
Thread.CurrentThread.CurrentUICulture
is set byUmbracoPublishedContentCultureProvider
which runs before any of the filters, meaning thatCurrentUICulture
was never set correctly, so to fix this I've made theEagerMatcherPolicy
detect if it's aUmbracoPageController
and then do the domain routing and setting a dummyUmbracoRouteValues
which is then used to assign the correctCurrentUICulture
by theUmbracoPublishedContentCultureProvider
.